Jump to content


[1.298] CRoom::RoomUserPunish() input crash


  • Please log in to reply
6 replies to this topic

#1 twostars

twostars

    KO Guru

  • GateKeeper
  • Others:Donator, Snoxd server contributor
  • 6,200 posts

Posted 11 February 2012 - 01:07 PM

Yet another missing length check. Also fixed in 1.310 by default.

0048688F    ^\EB AC         JMP SHORT 0048683D

0048683D      83C4 18       ADD ESP,18
00486840    83F9 15         CMP ECX,15
00486843    0F83 19010000   JNB 00486962
00486849    40              INC EAX
0048684A    51              PUSH ECX
0048684B    EB 44           JMP SHORT 00486891

004868A1      83C4 0C       ADD ESP,0C


#2 twostars

twostars

    KO Guru

  • GateKeeper
  • Others:Donator, Snoxd server contributor
  • 6,200 posts

Posted 18 February 2012 - 02:12 PM

Updated to include missing stack cleanup. You'll want to repatch.

#3 lUizitO159

lUizitO159

    Ex-developer latino.

  • Members
  • PipPipPipPip
  • 653 posts

Posted 21 April 2012 - 08:39 PM

what's this patch? what it does? fix any bug? or something? :D

#4 TheTompa

TheTompa

    Hacking Trainee

  • Donator
  • 76 posts

Posted 21 April 2012 - 09:23 PM

what's this patch? what it does? fix any bug? or something? :D

I think it's another way to crash the server, like this:
http://www.snoxd.net...3735#entry23735

#5 twostars

twostars

    KO Guru

  • GateKeeper
  • Others:Donator, Snoxd server contributor
  • 6,200 posts

Posted 22 April 2012 - 03:30 AM

Read the title. "Input crash".

It fixes a crash [method].

#6 lUizitO159

lUizitO159

    Ex-developer latino.

  • Members
  • PipPipPipPip
  • 653 posts

Posted 19 May 2012 - 07:35 PM

ebenezer?

#7 twostars

twostars

    KO Guru

  • GateKeeper
  • Others:Donator, Snoxd server contributor
  • 6,200 posts

Posted 19 May 2012 - 09:22 PM

Yup. If I don't explicitly state it, assume [game] server.